Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

AfterEffects: exposing Deadline pools fields in Publisher UI #6079

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Dec 20, 2023

Changelog Description

Deadline pools might be adhoc set by an artist during publishing. AfterEffects implementation wasn't providing this.

Additional info

Added render to class families filter as published instances are following product types (eg. render) and not additional values from families field (which are dynamically added and unknown after Creation phase of the instance.)

Known issue is possibility of showing fields for pools for locally rendered instances where it doesn't make sense. But changing family of the published instance to render.farm might have some unforeseeable side effects and it.

Note that this will now show for all render families, including:

Create Render in Unreal
Create Render in TV Paint
Create Movie Batch in Tray Publisher
Create Render in Harmony
Create Saver in Fusion (which it already did, because it had render.farm I believe?)
Create Render in After Effects
Create Render in Nuke

There should be eventually some cleanup of render product type, see #6078

Testing notes:

  1. create render instance (with enabled Deadline addon)
  2. it should add these fields:
AnyDesk_roDu1cno6g
  1. experiment with providing value, nonexistent pool name will trigger error:
AnyDesk_C1dYJS4Li4

As published instances follow product type `render` now, fields wouldn't be shown for them.
@ynbot
Copy link
Contributor

ynbot commented Dec 20, 2023

Task linked: OP-6421 AE: expose pool for Deadline render

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality module: Deadline AWS Deadline related features labels Dec 20, 2023
@kalisp kalisp added sponsored Client endorsed or requested target: OpenPype target: AYON labels Dec 20, 2023
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in Nuke and it seems to be showing the pool inputs

image

@jakubjezek001 jakubjezek001 removed their assignment Jan 3, 2024
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked in AE

@kalisp kalisp merged commit 5f837d6 into develop Jan 8, 2024
5 checks passed
@kalisp kalisp deleted the enhancement/OP-6421_AE-expose-pool-for-Deadline-render branch January 8, 2024 10:51
@ynbot ynbot added this to the next-patch milestone Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Deadline AWS Deadline related features size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested target: AYON target: OpenPype type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants