This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
AfterEffects: exposing Deadline pools fields in Publisher UI #6079
Merged
kalisp
merged 4 commits into
develop
from
enhancement/OP-6421_AE-expose-pool-for-Deadline-render
Jan 8, 2024
Merged
AfterEffects: exposing Deadline pools fields in Publisher UI #6079
kalisp
merged 4 commits into
develop
from
enhancement/OP-6421_AE-expose-pool-for-Deadline-render
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As published instances follow product type `render` now, fields wouldn't be shown for them.
kalisp
requested review from
64qam,
antirotor,
jakubjezek001,
iLLiCiTiT and
LiborBatek
December 20, 2023 15:48
Task linked: OP-6421 AE: expose pool for Deadline render |
ynbot
added
size/XS
Denotes a PR changes 0-99 lines, ignoring general files
type: enhancement
Enhancements to existing functionality
module: Deadline
AWS Deadline related features
labels
Dec 20, 2023
kalisp
added
sponsored
Client endorsed or requested
target: OpenPype
target: AYON
labels
Dec 20, 2023
BigRoy
reviewed
Dec 20, 2023
BigRoy
reviewed
Dec 20, 2023
jakubjezek001
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64qam
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked in AE
Limits this with higher precision.
kalisp
deleted the
enhancement/OP-6421_AE-expose-pool-for-Deadline-render
branch
January 8, 2024 10:51
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
module: Deadline
AWS Deadline related features
size/XS
Denotes a PR changes 0-99 lines, ignoring general files
sponsored
Client endorsed or requested
target: AYON
target: OpenPype
type: enhancement
Enhancements to existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Deadline pools might be adhoc set by an artist during publishing. AfterEffects implementation wasn't providing this.
Additional info
Added
render
to classfamilies
filter as published instances are following product types (eg.render
) and not additional values fromfamilies
field (which are dynamically added and unknown after Creation phase of the instance.)Known issue is possibility of showing fields for pools for locally rendered instances where it doesn't make sense. But changing
family
of the published instance torender.farm
might have some unforeseeable side effects and it.Note that this will now show for all render families, including:
Create Render in Unreal
Create Render in TV Paint
Create Movie Batch in Tray Publisher
Create Render in Harmony
Create Saver in Fusion (which it already did, because it had render.farm I believe?)
Create Render in After Effects
Create Render in Nuke
There should be eventually some cleanup of
render
product type, see #6078Testing notes:
render
instance (with enabled Deadline addon)