Chore: Use folder in cli arguments #197
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
module: Deadline
module: RoyalRender
size/XS
type: enhancement
iLLiCiTiT
added
Backwards incompatible
and removed
size/XS
type: enhancement
ynbot
added
module: Deadline
module: RoyalRender
type: enhancement
BigRoy
reviewed
Mar 19, 2024
client/ayon_core/modules/deadline/repository/custom/plugins/GlobalJobPreLoad.py
Outdated
Show resolved
Hide resolved
|
Waiting for #297 to be merged. |
# Conflicts: # client/ayon_core/cli.py # client/ayon_core/cli_commands.py # client/ayon_core/modules/deadline/repository/custom/plugins/GlobalJobPreLoad.py # client/ayon_core/modules/royalrender/lib.py
|
Looks good to me, but not sure if this command is actually still being used. @antirotor any idea what this one was for? |
Was used in royal render https://github.com/ynput/ayon-core/blob/develop/client/ayon_core/modules/royalrender/rr_root/plugins/control_job/perjob/m50__openpype_publish_render.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use
--folderinstead of--assetargument in command line interface.Additional info
Use folder over asset argument in command line interface.
Modified royal render and deadline to support new argument. Deadline plugin does support both options, tries to useThis PR affects only command--assetif first attempt fails.selectcontextused in royal render.