Maya: optional shader stripping for model #444
Conversation
antirotor
added
enhancement
host: Maya
sponsored
ynbot
added
type: enhancement
|
@antirotor I did upload new maya addon package (0.1.16) and also removed older ones from the ayon-docker repo but I cant see any settings on the server Seems there is some issue with the maya addon in this PR.
|
should be fixed |
There was a problem hiding this comment.
Hmm no matter if turning Strip Shader On or Off it ends up the pretty much the same
...both versions (v002) with stripping On and (v003) without any Striping of shaders ends up with same files sizes and also when inspecting those assets....all having InitialShading group assigned.
Im not sure if only should be propagated to OBJ but even when inspecting those assets I cant see any difference in kilobytes and inside the file...
And when inspected inside (OBJ file)
…ynput/ayon-core into enhancement/maya-allow-shaders-in-model
|
Should strip for OBJ too now |
| @@ -70,6 +70,9 @@ def process(self, instance): | |||
| noIntermediate=True, | |||
| long=True) | |||
|
|
|||
| strip_shader = instance.data.get("strip_shaders", True) | |||
| self.log.debug("Stripping shaders: %s" % strip_shader) | |||
There was a problem hiding this comment.
Is this debug log too verbose? Does it help debug certain edge cases?
There was a problem hiding this comment.
I think if you want to debug certain publish output - why your model comes without shaders, having this in the debug log can actually save you some time. But maybe it should be printed out only when strip shaders is enabled.
There was a problem hiding this comment.
I also wonder whether "strip shaders" is better than reversing the terminology and naming the option "include shaders" or "export shaders" which is how usually export options are shown (whether something is included or not, instead of whether it's stripped?)
There was a problem hiding this comment.
That term got there from the clients so I guess that is how they think about it. "Exporting models is stripping any shaders on them". What do you think @LiborBatek
There was a problem hiding this comment.
Totally understand it from the perspective of what model family has always been, etc. - But just looking at exporters in general and their terminology usage it's usually "what would you like to include"? That's why I wondered whether a export materials flag would be better?
Would love to know what Libor thinks as well. And maybe @dee-ynput from a product perspective.
|
Well to me its just really cosmetics...however the term
any of these is clear enough for pretty much anyone imho. Maybe the question is whether we should incorporate the new option in the Publisher as |
|
Please move to https://github.com/ynput/ayon-maya |
Changelog Description
Shaders are stripped from the model during extraction in Maya. This is adding option to disable that feature to retain shaders if needed.
Additional info
This is affecting OBJ extractor and Maya Scene model extractor. Default behavior is backwards compatible (stripping on), can be configured in creator settings.
Testing notes: