Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrayPublisher: adds new editorial exchange package product #484

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented May 3, 2024

Changelog Description

This PR adds new editorial_pckg product which should contain OTIO file with .mov resources in same published folder. Idea is to easily publish whole folder containing OTIO and movie files via Traypublisher.

Result would be new otio representation of editorial_pckg product type.

There is a validator looking for all movie files (from otio clip.media_references.target_url) present in uploaded folder (by simple name, whole target_url doesn't need to match, just name.)

Additional info

Next step (in separate PR) would be to create loader consuming .otio file into Resolve etc.
Test .otio provided by customer needed upgrade of OpenTimelineIO. Added to ayon-core/client/pyproject.toml

Testing notes:

  1. for conversion of resource files fill output definition ayon+settings://traypublisher/publish/ExtractEditorialPckgConversion?project=ayon_test (in similar fashion as ExtractReview)
    image
    3.upload whole folder containing .otio and .mov resource files

kalisp added 5 commits May 3, 2024 15:58
Should publish folder with otio file and (.mov) resources.
Collects otio_path and resource_paths from folder.
Doesn't parse and collect otio_data yet, to not carry too much data over.(Might be changed)
Currently checks only by file names and expects flat structure.
It ignores path to resources in otio file as folder might be dragged in and
published from different location than it was created.
Modifies otio file with rootless publish paths, prepares for integration.
@kalisp kalisp self-assigned this May 3, 2024
@ynbot ynbot added type: feature Adding something new and exciting to the product host: TrayPublisher size/S labels May 3, 2024
Added similar configuration as for ExtractReview to control possible conversion from .mov to target format (.mp4)
@ynbot
Copy link
Contributor

ynbot commented May 7, 2024

kalisp and others added 13 commits May 7, 2024 17:06
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
…torial_package.py

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
Got rid of profiles, didn't make much sense.
Git rid of multiple output definitions, didn't make sense with single otio file.
Settings have toggle to on/off conversion, this is exposed for Artist to decide ad-hoc.
Old 'path' clashed in output of instance attributes in Publisher.
@kalisp kalisp requested a review from jakubjezek001 May 10, 2024 12:58
@kalisp kalisp removed their assignment May 10, 2024
@kalisp kalisp marked this pull request as ready for review May 10, 2024 12:58
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
@jakubjezek001
Copy link
Member

Can we keep the default settings the same as you are having in the screen shot image please?

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubjezek001 jakubjezek001 merged commit fe50292 into develop May 14, 2024
1 check failed
@jakubjezek001 jakubjezek001 deleted the feature/AY-4801_traypublisher-publish-editorial-exchange-package-product branch May 14, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: TrayPublisher size/S type: feature Adding something new and exciting to the product
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants