-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrayPublisher: adds new editorial exchange package product #484
Merged
jakubjezek001
merged 25 commits into
develop
from
feature/AY-4801_traypublisher-publish-editorial-exchange-package-product
May 14, 2024
Merged
TrayPublisher: adds new editorial exchange package product #484
jakubjezek001
merged 25 commits into
develop
from
feature/AY-4801_traypublisher-publish-editorial-exchange-package-product
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should publish folder with otio file and (.mov) resources.
Collects otio_path and resource_paths from folder. Doesn't parse and collect otio_data yet, to not carry too much data over.(Might be changed)
Currently checks only by file names and expects flat structure. It ignores path to resources in otio file as folder might be dragged in and published from different location than it was created.
Modifies otio file with rootless publish paths, prepares for integration.
ynbot
added
type: feature
Adding something new and exciting to the product
host: TrayPublisher
size/S
labels
May 3, 2024
Added similar configuration as for ExtractReview to control possible conversion from .mov to target format (.mp4)
BigRoy
reviewed
May 7, 2024
client/ayon_core/hosts/traypublisher/plugins/create/create_editorial_package.py
Show resolved
Hide resolved
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
…torial-exchange-package-product
…torial_package.py Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
Got rid of profiles, didn't make much sense. Git rid of multiple output definitions, didn't make sense with single otio file.
Settings have toggle to on/off conversion, this is exposed for Artist to decide ad-hoc.
Old 'path' clashed in output of instance attributes in Publisher.
…ture/AY-4801_traypublisher-publish-editorial-exchange-package-product
Can we keep the default settings the same as you are having in the screen shot image please? |
…rror message handling in ValidateEditorialPackage.
jakubjezek001
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…torial-exchange-package-product
jakubjezek001
deleted the
feature/AY-4801_traypublisher-publish-editorial-exchange-package-product
branch
May 14, 2024 10:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR adds new
editorial_pckg
product which should containOTIO
file with .mov resources in same published folder. Idea is to easily publish whole folder containing OTIO and movie files via Traypublisher.Result would be new
otio
representation ofeditorial_pckg
product type.There is a validator looking for all movie files (from
otio clip.media_references.target_url
) present in uploaded folder (by simple name, wholetarget_url
doesn't need to match, just name.)Additional info
Next step (in separate PR) would be to create loader consuming
.otio
file into Resolve etc.Test
.otio
provided by customer needed upgrade of OpenTimelineIO. Added toayon-core/client/pyproject.toml
Testing notes:
ayon+settings://traypublisher/publish/ExtractEditorialPckgConversion?project=ayon_test
(in similar fashion asExtractReview
)3.upload whole folder containing
.otio
and.mov
resource files