Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: Utils cleanup & Project Delete #61

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Sync: Utils cleanup & Project Delete #61

wants to merge 13 commits into from
+187 −131

Conversation

scottmcdonnell
Copy link
Contributor

@scottmcdonnell scottmcdonnell commented Jun 14, 2024 •
edited
Loading

  • moves the project_delete from a httpx call to an entity call
  • fixes a bug for the setting path
  • adds Tests for deleting projects
  • Fixing a utils bug and reducing the code with some common functionality

@scottmcdonnell scottmcdonnell mentioned this pull request Jun 14, 2024
Closed
iLLiCiTiT
iLLiCiTiT reviewed Jun 18, 2024
View reviewed changes
server/kitsu/utils.py Outdated Show resolved Hide resolved
@iLLiCiTiT iLLiCiTiT changed the title Enhancement/utils cleanup Sync: Utils cleanup Jun 18, 2024
@scottmcdonnell @iLLiCiTiT
Update server/kitsu/utils.py
0094e6b 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@scottmcdonnell
Copy link
Contributor Author

this includes:

  • moves the project_delete from a httpx call to an entity call
  • fixes a bug for the setting path
  • adds Tests for deleting projects

@scottmcdonnell scottmcdonnell changed the title Sync: Utils cleanup Sync: Utils cleanup & Project Delete Jun 22, 2024
@MustafaJafar MustafaJafar added type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) test labels Jul 1, 2024
@iLLiCiTiT iLLiCiTiT added tests PR contains new unit or integration test or improves the existing ones and removed test labels Sep 17, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT left review comments

@martastain martastain Awaiting requested review from martastain

At least 1 approving review is required to merge this pull request.

Assignees

@martastain martastain

Labels
community Issues and PRs coming from the community members tests PR contains new unit or integration test or improves the existing ones type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottmcdonnell @iLLiCiTiT @martastain @MustafaJafar