Use event.code for keybind instead of event.key #46

prokhn · 2023-05-07T18:56:36Z

The problem is that using the "key" of the KeyboardEvent works correctly only within the same keyboard layout, so, for example, if the English layout is set, "key" will be "u", but if the Russian one is set, it will be "г". Therefore, it is better to use a universal key code for key bindings, which will be "KeyU" for any keyboard layout.

Resolves #46 - Use eventcode instead of eventkey

ynshung added bug Something isn't working good first issue Good for newcomers labels Jun 2, 2023

ynshung linked a pull request Jul 9, 2023 that will close this issue

Resolves #46 - Use eventcode instead of eventkey #57

Merged

ynshung added a commit to adsuth/better-yt-shorts that referenced this issue Jul 22, 2023

Merge branch 'master' into ynshung#46

9e8da84

ynshung closed this as completed in #57 Jul 22, 2023

ynshung added a commit that referenced this issue Jul 22, 2023

Merge pull request #57 from adsuth/#46

0b7671e

Resolves #46 - Use eventcode instead of eventkey

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use event.code for keybind instead of event.key #46

Use event.code for keybind instead of event.key #46

prokhn commented May 7, 2023

Use event.code for keybind instead of event.key #46

Use event.code for keybind instead of event.key #46

Comments

prokhn commented May 7, 2023