-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(follow): Add option to follow thumbstick #160
Conversation
Hey thank you for this, I'll have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it, the movement is great and all, works exactly as expected.
Well done. (Even tested with the square shape, and it's working 💯)
But there seems to be an offset somewhere as soon as I reach the border of the back piece.
Not sure where it is coming from.
Screen.Recording.2021-02-22.at.11.00.04.mov
Yep the offset is weird, in my project I set the zone to a specific div and it works as expected. Must be something css related, I'll take a look. |
It's probably the offset of the area to which the joystick is attached too. |
@emepetres I have a fix, which also fixes other things I believe. |
I went ahead and fixed it. |
Thank you both! |
sure thanks @yoannmoinet! I couldn't find time today to fix it, glad you did :) |
When follow option is set to true, the joystick follows the pointer when it reaches its border.
This is meant to improve usability on touch screens, when the user doesn't have the feedback of getting out the joystick zone.