Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traitor AI's 20 Nonexistent TCs just for an AI Camera Laser Gun #21118

Merged
merged 32 commits into from
Mar 8, 2024

Conversation

Runian
Copy link
Contributor

@Runian Runian commented Dec 16, 2023

Document the changes in your pull request

A new AI upgrade disk that can used at an AI Control Console to give an ability to an AI; disk item only obtained from adminbus.

The selected AI gets the ability to enter a burst mode which lets them shoot a laser from any functioning camera every second. It lasts for 30 seconds and be re-activated every 60 seconds. Cameras used in this matter are hit with a heavy EMP.

Installing one of the few AI upgrades (i.e, surveillance/malf upgrade) no longer runtimes.

Traitor AIs start with this ability.

More AI-centric than #20955.

Why is this good for the game?

Traitor AI is just traitor except you trade all of your TCs to be an AI. Those 20 TCs should get them something special, so here it is without giving them actual malf powers.

Testing

Shooting with nearby cameras at a distance.
moja-nocam

Shooting with an EMP-proof camera at pointblank range.
moja-cam

Spriting

No new sprites. This is what button looks like.
image

Wiki Documentation

Traitor AI gets this ability. Information in documentation above. Mention in the AI's wiki page in the antag section if there is a traitor specific category for it.

Changelog

🆑
rscadd: Only obtainable via a camera laser upgrade disk (or by being a traitor), the AI can get an ability based around lasers and their cameras.
rscadd: This new AI ability lets them enter a burst mode which lets them shoot a laser from any functioning camera every second. It lasts for 30 seconds and be re-activated every 60 seconds. Cameras used in this matter are hit with a heavy EMP.
bugfix: Hitting an AI control console with an upgrade no longer runtimes.
spellcheck: Logging regarding upgrading the AI with disks has better formatting.
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs labels Dec 16, 2023
@Moltijoe
Copy link
Contributor

So its exactly the same but its adminbus only? But why

@Runian
Copy link
Contributor Author

Runian commented Dec 16, 2023

So its exactly the same but its adminbus only? But why

image

@Moltijoe
Copy link
Contributor

Ah, didnt see that, ty

@Moltijoe
Copy link
Contributor

I still like moja's idea of it being an active where for a duration you can rapid fire shoot, and then it goes on cooldown

@Moltijoe Moltijoe added the Awaiting - Action - Balance Review Code Director Review label Dec 16, 2023
@Moja10
Copy link
Contributor

Moja10 commented Dec 20, 2023

Yeah like I said in the previous PR:
Make it so it can shoot rapidly, honestly anywhere between .5 to 1 second per shot, for a limited time, say 30 seconds, and then go on cooldown for 1 minute. Change numbers as you see fit, but that creates sudden burst of action and chaos rather than just 1 stinker every 10 seconds

otherwise, awesome idea

@JamieD1
Copy link
Contributor

JamieD1 commented Jan 10, 2024

I mean feels a bit useless, like when will you actually use other then to try and snipe people when they are already low. I mean we can try but it feels like a bit of a noob trap.

@TheGamerdk
Copy link
Contributor

I mean feels a bit useless, like when will you actually use other then to try and snipe people when they are already low. I mean we can try but it feels like a bit of a noob trap.

Mojas suggestion would be better, imo

@Runian
Copy link
Contributor Author

Runian commented Jan 13, 2024

@Moltijoe changed. reapprove for balance council if need be
@Moja10 @TheGamerdk suggestion done

@Moltijoe Moltijoe added the Awaiting - Action - Testing TEST YOUR STUFF label Feb 4, 2024
@cowbot92 cowbot92 added Awaiting - Action - Testing TEST YOUR STUFF and removed Awaiting - Action - Testing TEST YOUR STUFF labels Feb 5, 2024
@cowbot92
Copy link
Contributor

cowbot92 commented Feb 5, 2024

((didnt mean to remove it tried to click on the wrong stuff, lol!))

@Runian
Copy link
Contributor Author

Runian commented Feb 7, 2024

@Moltijoe Testing updated

@Moltijoe Moltijoe removed the Awaiting - Action - Testing TEST YOUR STUFF label Feb 15, 2024
Copy link
Contributor

@TheGamerdk TheGamerdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner review. Did not perform code review

@Moltijoe Moltijoe added Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer DO NOT MERGE Should not be merged without express approval from a Head Dev labels Feb 16, 2024
@Moltijoe
Copy link
Contributor

Do not merge label added so manatee doesnt merge it without realizing

@CrazyDrakkon
Copy link

No podperson is safe

@Moltijoe Moltijoe removed DO NOT MERGE Should not be merged without express approval from a Head Dev Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer labels Mar 8, 2024
@Moltijoe Moltijoe merged commit fa79635 into yogstation13:master Mar 8, 2024
12 checks passed
Yogbot-13 added a commit that referenced this pull request Mar 8, 2024
@Runian Runian deleted the ailaserbeam branch March 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Council Approved This PR was approved by the Balance Council. Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants