Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the gap between station & lavaland #22089

Merged
merged 1 commit into from
May 31, 2024

Conversation

ynot01
Copy link
Contributor

@ynot01 ynot01 commented May 22, 2024

Document the changes in your pull request

Mining shuttles now take 1 second to depart and 1 second to arrive

Why is this good for the game?

Optimally, station & planet z-level would be one in the same, but this is a step closer. By making transit incredibly fast, planetside becomes a lot less exclusive. Inspired by IceMeta's ladder

Testing

It goes fast

Wiki Documentation

See documentation

Changelog

馃啈
tweak: The mining shuttle engines have had their safeties disabled, making interplanetary travel faster than ever before.
/:cl:

@ynot01 ynot01 requested a review from a team as a code owner May 22, 2024 21:50
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label May 22, 2024
@Beeper-Skeeper
Copy link
Contributor

How fast?

@Beeper-Skeeper
Copy link
Contributor

damm thats fast
10

@github-actions github-actions bot added the Mapping Will result in a change to a map. label May 22, 2024
@SapphicOverload
Copy link
Contributor

A space elevator instead of a shuttle would be cool

@ynot01
Copy link
Contributor Author

ynot01 commented May 22, 2024

A space elevator instead of a shuttle would be cool

Do I look like a mapper to you

@Addust
Copy link
Contributor

Addust commented May 22, 2024

A space elevator instead of a shuttle would be cool

Do I look like a mapper to you

you are want mapping? can do maybe

Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map code is fine.

I'm on the fence about this since the wait gives some much needed reprieve, and mining is usually pretty fast paced. Worst case scenario people don't like it and we revert it, so sure.

@neeshacark
Copy link
Contributor

im not overly a big fan, ganking people on the shuttle should remain a viable option

also it might not be a good idea for balance because this means you have the hypersonic ling gibber 90000 and it gives very little time to get out of the way of the LZ should you be passing under it as it lands

@ynot01
Copy link
Contributor Author

ynot01 commented May 25, 2024

also it might not be a good idea for balance because this means you have the hypersonic ling gibber 90000 and it gives very little time to get out of the way of the LZ should you be passing under it as it lands

putting lings on an office chair (of which one spawns directly next to the mining shuttle) negates any ability to escape in the first place so i dont see this as a major loss, lings have way bigger problems than shuttle speed right now

@SapphicOverload
Copy link
Contributor

Having only one second to get out of the way is going to get a lot of people gibbed by accident.

@ynot01
Copy link
Contributor Author

ynot01 commented May 30, 2024

Having only one second to get out of the way is going to get a lot of people gibbed by accident.

Don't stand in the area clearly marked by danger lines

@Moltijoe Moltijoe merged commit 50f94ba into yogstation13:master May 31, 2024
14 checks passed
Yogbot-13 added a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants