Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeZone issue #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix TimeZone issue #55

wants to merge 2 commits into from

Conversation

jpottier
Copy link
Contributor

Use DateTime object comparison to avoid Timezone issue

$this->contains($event->getBegin()) ||
($event->getEnd() && $this->contains($event->getEnd()) && $event->getEnd()->format('c') !== $this->begin->format('c'))
;
return $event->getBegin() < $this->getEnd() && $event->getEnd() > $this->getBegin();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any unit test about this expected behavior is same as actual?

I think it needs some tests to present that this can fix the timezone issue :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants