chore(): Add Symfony 5 support #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
reviewed
Feb 10, 2021
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| "require": { | |||
| "php": "^5.5|^7.0", | |||
| "symfony/options-resolver": "^2.7|^3.0|^4.0" | |||
| "symfony/options-resolver": "^2.7|^3.0|^4.0|^5.0" | |||
There was a problem hiding this comment.
I think you should remove support for Symfony below 4.4
peter279k
added a commit
to peter279k/fork-CalendR
that referenced
this pull request
May 7, 2021
|
Dear @garak, @juanmiguelbesada. Just notice that this PR I've resolved/merged on my forked repository. It can refer peter279k#6 and peter279k#8. If having any issue/problems, please don't hesitate to submit issue on https://github.com/peter279k/fork-CalendR/issues :). |
peter279k
added a commit
to peter279k/fork-CalendR
that referenced
this pull request
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR. add support for Symfony 5.x.
It also fixed a error on twig 2 with silex