Feature visualisation #17
Conversation
examples/rendered-graph.php
Outdated
|
|
||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
|
|
||
| // Implement your document class |
There was a problem hiding this comment.
this is not a clear comment please fix or remove
|
please provide some sort of documentation with this PR |
|
I'll review this PR soon, but i'm not for generating the picture from Finite. I think generating the dot file is enough, and it removes lot of potential issues (with |
|
i agree with @yohang , maybe add a folder for a silex or cilex or symfony command for those who want to run the command and do it |
|
I've polished the code a bit. Reference to graphviz as dependency is still missing. I'm not sure about that. If you don't want to run graphviz and just have the dot source, just specify a file having a ".dot" extension as output. |
| $output = 0; | ||
| $tempFile = tempnam(sys_get_temp_dir(), 'dot'); | ||
| $this->dumpGraphToFile($tempFile); | ||
| exec('dot -T' . $this->type . ' -o' . $target . ' ' . $tempFile, $output, $returnVar); |
There was a problem hiding this comment.
As I say in my previous comment, I don't think Finite have to generate the graph has a picture. Generating the dotfile should be enough.
|
I let you some comments, the point is that I don't want Finite to deal with the filesystem and / or OS. I really want to avoid any kind of |
|
OK, thanks for the feedback. I'll try to address it at the weekend. |
|
👍 |
|
👍 |
|
Any news on this? |
Concerning #16
A configuration value object has been introduced to control if properties shall be rendered and the color of the current state.