Remove StatefulInterface from type hint

[winzou]

To be fully compliant with the new property access strategy.
Otherwise, I can't use the TwigExtension for example.

[cordoval]

should this rather be a common interface? is there any other way to accomplish this?

[winzou]

As far as I know there is no other way. We can dynamically define under which property path is the state of the object, so it can't be achieved by a static interface.

[cordoval]

there must be a way, cc/ @matthiasnoback
I feel like removing interfaces like this should be thought well

[winzou]

@yohang @cordoval if the passed object is not the good one, then the Factory won't find an associated loader. But as per https://github.com/yohang/Finite/blob/master/src/Finite/Factory/AbstractFactory.php#L33 this won't throw any exception. Maybe we should throw one if $loader is null there?

[yohang]

There is 2 problems here,

1. The interface is no longer useful, and we have no way to "flag" an object as Stateful. We should maybe process checks on the available properties defined by the state accessor.

   The StatefulInterface is still interesting for people that define only one graph, with minimal configuration (with the default property_path being finiteState)

2. As @winzou says, we have to identify incompatible objects given to the factory, but that's not easy as the loader isn't mandatory. I don't see use case for using the Factory without Loader, but removing this won't be BC.

In all case, I'll merge this PR as there is no more StatefullInterface typehints in Finite code, as this is wrong with the property path strategy, so there is no reasons to keep it in Context and Twig extension.

[winzou]

ping @yohang

[yohang]

Missed this one, sorry.

Merged ;)