Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return ErrConnClosed if write frame failed #674

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Nov 16, 2023

No description provided.

@woorui woorui self-assigned this Nov 16, 2023
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
yomo ⬜️ Ignored (Inspect) Nov 16, 2023 5:13pm

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a628936) 59.33% compared to head (91d7597) 59.27%.

Files Patch % Lines
pkg/listener/quic/quic.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   59.33%   59.27%   -0.07%     
==========================================
  Files          36       36              
  Lines        2715     2718       +3     
==========================================
  Hits         1611     1611              
- Misses       1004     1006       +2     
- Partials      100      101       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@fanweixiao fanweixiao added the bug Something isn't working label Nov 17, 2023
@fanweixiao fanweixiao merged commit ccfcc5a into master Nov 17, 2023
5 of 7 checks passed
@fanweixiao fanweixiao deleted the fix/write-frame branch November 17, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants