Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dependency management #1289

Merged
merged 10 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions .github/workflows/build-check-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of SonarQube analysis
path: 'yona-server'
- name: Set up JDK 11
- name: Set up JDK
uses: actions/setup-java@v4.0.0
with:
distribution: 'temurin'
Expand Down Expand Up @@ -247,18 +247,6 @@ jobs:
done
echo "ERROR: Helm chart is NOT available after ${totalSleepDuration} seconds"
exit 1
- name: Publish Gradle dependencies
if: ${{ !inputs.is-pr-build }}
uses: mikepenz/gradle-dependency-submission@v1.0.0
with:
gradle-project-path: yona-server
gradle-build-module: |-
:core
:dbinit
:analysisservice
:adminservice
:appservice
:batchservice
- name: Notify regular build success through Slack
if: ${{ success() && !inputs.is-pr-build }}
uses: slackapi/slack-github-action@v1.25.0
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/build-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,25 @@ jobs:
DOCKER_HUB_PASSWORD: ${{ secrets.DOCKER_HUB_PASSWORD }}
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

dependency-submission:
name: Publish dependencies
needs:
- build-check-publish
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: Checkout src repo
uses: actions/checkout@v4
- name: Set up JDK
uses: actions/setup-java@v4.0.0
with:
distribution: 'temurin'
java-version: 17
- name: Publish Gradle dependencies
uses: gradle/actions/dependency-submission@v3


deploy-load-test-server:
if: ${{ false }} # Load test server not available anymore
name: Deploy load test server
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,30 @@ jobs:
checks: write
issues: write
pull-requests: write

dependency-submission:
name: Publish dependencies
needs:
- build-check-publish
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: Checkout src repo
uses: actions/checkout@v4
- name: Set up JDK
uses: actions/setup-java@v4.0.0
with:
distribution: 'temurin'
java-version: 17
- name: Publish Gradle dependencies
uses: gradle/actions/dependency-submission@v3

# review-dependencies:
# name: Review dependencies
# needs:
# - dependency-submission
# runs-on: ubuntu-latest
# steps:
# - name: Review dependencies
# uses: actions/dependency-review-action@v4.0.0
Loading