Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Enhance unused Jobs discovery #315

Closed
doronkg opened this issue Jun 18, 2024 · 2 comments · Fixed by #336
Closed

feature: Enhance unused Jobs discovery #315

doronkg opened this issue Jun 18, 2024 · 2 comments · Fixed by #336
Assignees
@nati-elmaliach
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@doronkg
Copy link
Contributor

doronkg commented Jun 18, 2024

Following #283, we added another indication for unused Jobs for Job that had reached BackoffLimit and failed.

Add the following indications to enhance the discovery:

  1. Jobs that failed with DeadlineExceeded.
  2. Job that failed with FailedIndexes which is another type of BackoffLimit.
  3. Suspended Jobs.
@yonahd yonahd added enhancement New feature or request good first issue Good for newcomers labels Jun 18, 2024
@nati-elmaliach
Copy link
Contributor

nati-elmaliach commented Jul 25, 2024 •
edited
Loading

Hey 👋
I’ll be happy to take this on. @doronkg , should this be three separate PRs or a single one?

@doronkg
Copy link
Contributor Author

doronkg commented Jul 25, 2024

Hey 👋 I’ll be happy to take this on. @doronkg , should this be three separate PRs or a single one?

Hey @nati-elmaliach, thanks for reaching out to contribute!

One PR that includes all three indications is fine, just make sure to cover everything with tests and differentiate the reasons why the job was considered unused.

Feel free to consult with us regarding the implementation and share your perspective on the scope of the issue.

@yonahd please assign the issue.

@nati-elmaliach nati-elmaliach mentioned this issue Jul 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nati-elmaliach nati-elmaliach

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Enhance unused jobs discovery nati-elmaliach/kor
3 participants
@nati-elmaliach @yonahd @doronkg