-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add failed jobs as unused #283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 40.84% 40.96% +0.12%
==========================================
Files 58 58
Lines 2904 2910 +6
==========================================
+ Hits 1186 1192 +6
Misses 1530 1530
Partials 188 188 ☔ View full report in Codecov by Sentry. |
Left small suggestion. Few thoughts, as we're shifting the way we approach unused Jobs from just completed ones:
|
This PR adds a case where A Job has failed and reached it's maximum retries.
This pod should now be considered unused
What this PR does / why we need it?
PR Checklist