Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jobs cleaner #168

Merged
merged 3 commits into from
Dec 4, 2023
Merged

feat: add jobs cleaner #168

merged 3 commits into from
Dec 4, 2023

Conversation

cindyliu-tec
Copy link
Contributor

add a job resource cleaner, when a job's status.completedTime field has value, consider the job is completed, is safe to delete

Copy link
Contributor Author

@cindyliu-tec cindyliu-tec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed by myself

@yonahd
Copy link
Owner

yonahd commented Nov 29, 2023

Amazing contribution!
Overall looks great. I'll do a final review after you make the small adjustments to pass gating

@codecov-commenter
Copy link

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (7f0367f) 45.52% compared to head (d617d57) 45.96%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/kor/jobs.go 56.00% 14 Missing and 8 partials ⚠️
pkg/kor/all.go 0.00% 9 Missing ⚠️
pkg/kor/delete.go 0.00% 7 Missing ⚠️
pkg/kor/multi.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   45.52%   45.96%   +0.43%     
==========================================
  Files          21       22       +1     
  Lines        1990     2080      +90     
==========================================
+ Hits          906      956      +50     
- Misses        930      962      +32     
- Partials      154      162       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/kor/jobs.go Outdated Show resolved Hide resolved
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit 6ee6450 into yonahd:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants