Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: show unused reason #278

Merged
merged 18 commits into from
Jun 17, 2024
Merged

Feat: show unused reason #278

merged 18 commits into from
Jun 17, 2024

Conversation

yonahd
Copy link
Owner

@yonahd yonahd commented May 21, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes test for any new code

Github Issue

[#167 ]

@yonahd yonahd marked this pull request as draft May 21, 2024 11:13
@yonahd
Copy link
Owner Author

yonahd commented Jun 3, 2024

Screenshot 2024-06-03 at 22 39 34 Example output

@yonahd yonahd marked this pull request as ready for review June 4, 2024 19:16
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 47.01835% with 231 lines in your changes missing coverage. Please review.

Project coverage is 41.21%. Comparing base (ea85ff7) to head (04aa206).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/kor/formatter.go 9.27% 134 Missing and 3 partials ⚠️
pkg/kor/delete.go 15.09% 45 Missing ⚠️
pkg/kor/crds.go 0.00% 6 Missing ⚠️
pkg/kor/multi.go 0.00% 5 Missing ⚠️
pkg/kor/pdbs.go 61.53% 5 Missing ⚠️
pkg/kor/all.go 0.00% 4 Missing ⚠️
pkg/kor/finalizers.go 70.00% 3 Missing ⚠️
pkg/kor/services.go 80.00% 3 Missing ⚠️
pkg/kor/statefulsets.go 78.57% 3 Missing ⚠️
pkg/kor/hpas.go 75.00% 2 Missing ⚠️
... and 16 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   40.87%   41.21%   +0.34%     
==========================================
  Files          58       59       +1     
  Lines        2953     3113     +160     
==========================================
+ Hits         1207     1283      +76     
- Misses       1545     1627      +82     
- Partials      201      203       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd
Copy link
Owner Author

yonahd commented Jun 4, 2024

@luisdavim @doronkg
If you can take a look that would be great

cmd/kor/root.go Outdated Show resolved Hide resolved
pkg/kor/kor.go Outdated Show resolved Hide resolved
pkg/kor/formatter.go Outdated Show resolved Hide resolved
pkg/kor/replicaset.go Outdated Show resolved Hide resolved
pkg/kor/formatter.go Outdated Show resolved Hide resolved
Copy link
Contributor

@doronkg doronkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Small fixes in reason descriptions.

pkg/kor/hpas.go Outdated Show resolved Hide resolved
pkg/kor/storageclasses.go Outdated Show resolved Hide resolved
@yonahd yonahd merged commit 107c885 into main Jun 17, 2024
1 check passed
@yonahd yonahd linked an issue Jun 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add reason for marking as unused
3 participants