Allow running offline without specified version #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
reviewed
Mar 22, 2020
Inform users about local fallback
|
@yonaskolb yes of course! I replaced the path logic to determine currently installed versions with the cache of #170, but I am not sure if this part is fine. |
vknabel
commented
Apr 18, 2020
Sources/MintKit/Mint.swift
Outdated
Comment on lines
176
to
185
| let metadata = try readMetadata() | ||
| let linkedExecutables = getLinkedExecutables() | ||
| let cache = try Cache(path: packagesPath, metadata: metadata, linkedExecutables: linkedExecutables) | ||
|
|
||
| guard let installedVersions = cache.packages | ||
| .first(where: { $0.gitRepo == package.repo })? | ||
| .versionDirs.map({ $0.version }), | ||
| let fallbackVersion = installedVersions.first else { | ||
| throw MintError.repoNotFound(package.gitPath) | ||
| } |
There was a problem hiding this comment.
Now this logic relies on the changes of #170. Is it fine to instantiate the Cache in here?
toshi0383
reviewed
May 4, 2020
It’s more likely to be the latest version
|
@vknabel could you add a changelog entry as well |
|
@yonaskolb oh yes, of course! |
yonaskolb
approved these changes
May 13, 2020
|
This doesn't seem to work in the latest version. If I run it locally the command fails @vknabel @yonaskolb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the version cannot be resolved while being offline, this PR will try to find locally installed versions. It will try to use the latest version.
This fixes #164