Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid test utility module in some packages. #251

Merged
merged 1 commit into from Nov 20, 2022
Merged

Avoid test utility module in some packages. #251

merged 1 commit into from Nov 20, 2022

Conversation

417-72KI
Copy link
Contributor

Resolves #250

I tried to run mint install with this fix and succeeded on SwiftLint, SwiftFormat and SSGH(my original package).

@417-72KI 417-72KI mentioned this pull request Oct 21, 2022
Closed
yonaskolb
yonaskolb approved these changes Nov 20, 2022
View reviewed changes
Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @417-72KI

@yonaskolb yonaskolb merged commit 8a82de5 into yonaskolb:master Nov 20, 2022
@417-72KI 417-72KI deleted the set-product-on-build-command branch November 20, 2022 10:43
@yonaskolb yonaskolb mentioned this pull request Dec 1, 2022
Merged
@tid-kijyun tid-kijyun mentioned this pull request Dec 1, 2022
Closed
This was referenced Dec 12, 2022
Closed
Merged
vincentisambart
vincentisambart reviewed Dec 12, 2022
View reviewed changes
Sources/MintKit/Mint.swift
@@ -331,6 +331,9 @@ public class Mint {
}

var buildCommand = "swift build -c release"
for executable in executables {
buildCommand += " --product \(executable)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this seems to only build the last executable specified (#255), so I had to make Mint run swift build for each executable (#256).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentisambart vincentisambart vincentisambart left review comments

@yonaskolb yonaskolb yonaskolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running (or rather, building) swiftlint 0.50.0-rc.1 fails
3 participants
@417-72KI @vincentisambart @yonaskolb