TT-97 workaround for https://bugs.swift.org/browse/SR-1386 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove top level namespace - move coding options into a new Config namespace - pull tags, version and Server out to the top level - if no tags, create Operation namespace
Sync fork - support object in query params
|
@yonaskolb can you look at this when you have a chance? |
|
Thanks for this @Kastet, and sorry it's taken me so long to get around to this. As you know probably by now you can create your own template and point to that as well, so official SwagGen releases don't hold you up. As this is a breaking change anyway, it would be nice to group the tags under something as well. I find the code completion really helps. You have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #153
Changes:
ConfignamespaceOperationnamespaceNewly generated API library should not have many braking changes - only references to coding options would need to be updated - references to operations should continue working via the old namespace as it matches the module name.