Added support for dependency destination specification. (Resolves #1038)

[JakubBednar]

No description provided.

[freddi-kit]

Hello, @JakubBednar. Before submitting a pull request, please add a test to it. Please refer to the test topic in CONTRIBUTING.md https://github.com/yonaskolb/XcodeGen/blob/master/CONTRIBUTING.md#tests

[JakubBednar]

Hello, frankly it is harder for me to navigate your unit-tests than to update the actual code and add the feature. :) So I was hopping to get a general feedback on the proposed feature and solution first. If you'd agree that this is something that makes sense to you and the proposed way of implementation is correct as well I will add the tests. But if you decide that you do not want this feature or you want it implemented differently than I would be just wasting my time on the tests. (I did test it on my use-case and generated my project with this. Embedding command-line-tools and frameworks to custom locations)

With that said, I suppose I should extend both ProjectSpecTests and PBXProjGeneratorTests. Or is there anything else?

[freddi-kit]

Thank you for your update and I'm sorry for my late reply. Now I became Collaborator for this repo so please give a time to learn and I'll review it soon!

[JakubBednar]

Hello, @freddi-kit. Anything I can do to make this get merged?

[jakubkiermasz-zd]

Hello!
Seems like this resolves #1102, doesn't it :)?

@JakubBednar, @freddi-kit any updates?

[jakubkiermasz-zd]

If you are interested, https://github.com/zendesk/XcodeGen is the fork aligned with the develop that we will use till it's merged.

[yonaskolb]

Thanks for the great work here @JakubBednar. It all seems good. Only thing is I'm a little hesitant to merge 1700 lines of testing code that will have to be maintained. If you can reduce this a bit with the use of some helper functions or some setup objects that would be great. Once done and the conflicts are resolved, we can get this merged 👍

@jakubkiermasz-zd are you confirming this solves your particular use case?

[freddi-kit]

Ah sorry for not adding comments for a long time, I thought I asked others to review but it looks ask review button in github not worked when I tapping, sorry. 🙇

[jakubkiermasz-zd]

@yonaskolb I am. It works like a charm ^^

Regarding the conflicts: you can use the fork I've posted above ^^

[JakubBednar]

I have resolved the conflicts and removed IMO the only boiler-plate code in the unit-tests. @yonaskolb , please note the following about the unit-tests:

1. I did cover all available dependency types and there is a lot of them. Therefore a lot of tests.
2. For each dependency type, the first test actually fixes how xcodegen worked before changes. For some dependency types it ignored embed: true for some it ignored embed: false. I did not change the default behaviour without specifying the custom copy phase. The only target type that still ignores custom copy phase is the Bundle dependency type. See the last two unit-tests.

[yonaskolb]

Can we move this up into Next Version

[yonaskolb]

Great, thank you @JakubBednar