Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use link property in framework deps #532

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Conversation

dimatosaurus
Copy link

Allows using link property in framework dependencies. This is needed
if you use firebase as a framework dependency.

@brentleyjones
Copy link
Collaborator

We use Firebase at our company, and we don't need this change. Can you give a fuller example of how this is broken without this change?

@dimatosaurus
Copy link
Author

We use firebase as framework dependency (not Carthage) in a framework that we ship
with our app. Linking the firebase libs prohibits the upload to the app store, since no
Bitcode is included in the firebase libraries. Linking is also not necessary here.

The change is similar to the Carthage change that was posted a while ago. Since we
do not use Carthage to fetch the framework, we needed a similar behavior.

@yonaskolb
Copy link
Owner

Thanks @dimatosaurus. At first glance this seems to check out. Look good to you @brentleyjones?

@dimatosaurus could you add a changelog entry as well?

@yonaskolb yonaskolb merged commit 2868c32 into yonaskolb:master Mar 22, 2019
@yonaskolb
Copy link
Owner

Added changelog in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants