Add LoRA to BLOOM #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongzx
reviewed
Jun 28, 2022
|
@haileyschoelkopf can you separate prefix tuning from this PR (by creating another PR)? I have tested LoRA and the implementation looks correct! Once I have obtained the training curves from |
|
I've just done this! Will open a separate PR for prefix tuning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LoRA to adapter-transformers' BLOOM implementation.
I have verified that with no LoRA adapter added to the model (just using
pfeiffer+invconfig for adapters), the performance is exactly the same (with a seed set) as before I added this change.so this can be safely merged for us to try out.
TODO:
madx_run_clm.pyusing a LoRA adapter (+ determine appropriate config values.)