Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support concurrent formatting of Text #116

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Support concurrent formatting of Text #116

merged 2 commits into from
Oct 16, 2023

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Sep 20, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum added this to the 0.4.7 milestone Sep 20, 2023
@humdrum humdrum self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 11.92% and project coverage change: -0.90% ⚠️

Comparison is base (38ea3c2) 44.24% compared to head (84ed297) 43.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   44.24%   43.35%   -0.90%     
==========================================
  Files         105      105              
  Lines       22229    22888     +659     
==========================================
+ Hits         9836     9922      +86     
- Misses      12393    12966     +573     
Files Changed Coverage Δ
Sources/API/Converter.swift 43.45% <0.00%> (-0.20%) ⬇️
Sources/API/V1/yorkie/v1/resources.pb.swift 6.83% <0.00%> (-0.03%) ⬇️
Tests/Integration/TextIntegrationTests.swift 0.00% <0.00%> (-1.39%) ⬇️
Sources/Document/CRDT/CRDTText.swift 88.99% <100.00%> (+2.90%) ⬆️
Sources/Document/CRDT/RGATreeSplit.swift 78.38% <100.00%> (+0.72%) ⬆️
Sources/Document/Json/JSONText.swift 66.88% <100.00%> (+6.48%) ⬆️
Sources/Document/Operation/StyleOperation.swift 53.65% <100.00%> (+1.15%) ⬆️
Tests/Unit/Document/DocumentTests.swift 98.58% <100.00%> (ø)
Tests/Unit/Document/JSONTextTest.swift 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@humdrum humdrum merged commit f15db57 into main Oct 16, 2023
3 checks passed
@humdrum humdrum deleted the concurrent-formatting branch October 16, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants