Fix bug when setting non-string values in Presence #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
presence-non-string
branch
3 times, most recently
from
49c0856
to
989ae41
Compare
hackerwins
force-pushed
the
presence-non-string
branch
from
989ae41
to
da50e8d
Compare
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 86.73% 86.74% +0.01%
==========================================
Files 70 70
Lines 4704 4709 +5
Branches 496 496
==========================================
+ Hits 4080 4085 +5
Misses 436 436
Partials 188 188
Continue to review full report at Codecov.
|
hackerwins
added a commit
that referenced
this pull request
Jun 13, 2022
parkeunae
pushed a commit
to parkeunae/yorkie-js-sdk
that referenced
this pull request
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Fix bug when setting non-string values in Presence
Any background context you want to provide?
What are the relevant tickets?
Fixes #301
Checklist