Imporove splay delete #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two problems in `deleteNodes`. 1. repeat splay for each node to be deleted resulting in numerous rotations. 2. not actually delete node, zero-weight node left and affect. To improve the deletion, this commit skips splay for nodes in between and isolates in a subtree then cut off the subtree.
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 87.53% 87.48% -0.05%
==========================================
Files 70 70
Lines 4948 4993 +45
Branches 497 505 +8
==========================================
+ Hits 4331 4368 +37
- Misses 433 441 +8
Partials 184 184
Continue to review full report at Codecov.
|
This was referenced Jun 22, 2022
hackerwins
pushed a commit
that referenced
this pull request
Jun 28, 2022
There were some bugs in #312 and #316 after applying range deletion. 1. Deletion does not apply intermittently on remote peers. 2. When typing Korean, intermediate traces remain. 3. Index error when editing the end of the text 4. Randomly occurring runtime errors This commit fixes most of the bugs in #312 and #316. Bug 4 was related to the GC, so the GC was modified a little.
hackerwins
pushed a commit
that referenced
this pull request
Jun 28, 2022
There were some bugs in #312 and #316 after applying range deletion. 1. Deletion does not apply intermittently on remote peers. 2. When typing Korean, intermediate traces remain. 3. Index error when editing the end of the text 4. Randomly occurring runtime errors This commit fixes most of the bugs in #312 and #316. Bug 4 was related to the GC, so the GC was modified a little.
2 tasks
parkeunae
pushed a commit
to parkeunae/yorkie-js-sdk
that referenced
this pull request
Jul 23, 2022
There were two problems in `deleteNodes`. 1. repeat splay for each node to be deleted resulting in numerous rotations. 2. not actually delete node, zero-weight node left and affect. To improve the deletion, this commit skips splay for nodes in between and isolates in a subtree then cut off the subtree.
parkeunae
pushed a commit
to parkeunae/yorkie-js-sdk
that referenced
this pull request
Jul 23, 2022
There were some bugs in yorkie-team#312 and yorkie-team#316 after applying range deletion. 1. Deletion does not apply intermittently on remote peers. 2. When typing Korean, intermediate traces remain. 3. Index error when editing the end of the text 4. Randomly occurring runtime errors This commit fixes most of the bugs in yorkie-team#312 and yorkie-team#316. Bug 4 was related to the GC, so the GC was modified a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
There were two problems in
deleteNodes.To improve the deletion, this commit skips splay for nodes in between and
isolates in a subtree then cut off the subtree.
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist