Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client sync mode #495

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Add Client sync mode #495

merged 5 commits into from
Apr 17, 2023

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Apr 13, 2023

What this PR does / why we need it?

  • Implement Client Sync mode
    • In pushOnly mode,
      • Set pushOnly flag in the PushPull API.
      • Don't apply remote changes.

Any background context you want to provide?

What are the relevant tickets?

Related yorkie-team/yorkie#500, yorkie-team/yorkie-ios-sdk#65

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #495 (3ec225a) into main (6e2c501) will increase coverage by 0.12%.
The diff coverage is 93.49%.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   90.04%   90.17%   +0.12%     
==========================================
  Files          69       70       +1     
  Lines        5989     6148     +159     
  Branches      569      578       +9     
==========================================
+ Hits         5393     5544     +151     
- Misses        388      392       +4     
- Partials      208      212       +4     
Impacted Files Coverage Δ
src/yorkie.ts 100.00% <ø> (ø)
src/client/client.ts 73.53% <64.51%> (-0.81%) ⬇️
src/client/attachment.ts 77.77% <100.00%> (+1.03%) ⬆️
src/document/document.ts 73.29% <100.00%> (+0.50%) ⬆️
test/integration/client_test.ts 99.78% <100.00%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chacha912 chacha912 force-pushed the sync-mode branch 4 times, most recently from ff006e4 to 01aadfa Compare April 17, 2023 02:11
@chacha912 chacha912 marked this pull request as ready for review April 17, 2023 05:52
@hackerwins hackerwins self-requested a review April 17, 2023 06:36
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 913d608 into main Apr 17, 2023
1 check passed
@hackerwins hackerwins deleted the sync-mode branch April 17, 2023 06:37
hunkim98 pushed a commit to hunkim98/yorkie-js-sdk that referenced this pull request Jul 12, 2023
Co-authored-by: Youngteac Hong <susukang98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants