Add Leader Election for Housekeeping in Sharded Cluster using K8s Lease #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krapie
force-pushed
the
shard-cluster-housekeeping
branch
from
6f9ed44
to
5f6191a
Compare
krapie
changed the title
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 50.61% 50.50% -0.12%
==========================================
Files 64 64
Lines 5751 5766 +15
==========================================
+ Hits 2911 2912 +1
- Misses 2471 2484 +13
- Partials 369 370 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
krapie
changed the title
krapie
changed the title
|
Since we plan to continue this with #529, I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add leader election for housekeeping in sharded cluster.
server/backend/electionpackage is added for leader election, and it uses K8s client-go's leaderelection package to simplify implementation of leader election.yorkie-clusterHelm Chart is configured to support leader election between yorkie servers, with K8s Lease object.hostnamevalue inserver/backend/backend.gois fixed. For more information, follow: Add user agent metrics PRWhich issue(s) this PR fixes:
Fixes #505
Special notes for your reviewer:
Yorkie server will have K8s dependency when using leader election in cluster mode, but since cluster mode is already dependent on K8s, including K8s dependent code will be okay.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: