-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Presence to Document #577
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
presence-batch-move-presence
branch
from
July 7, 2023 10:12
6ee616b
to
ed82e0d
Compare
2 tasks
hackerwins
force-pushed
the
presence-batch-move-presence
branch
2 times, most recently
from
July 7, 2023 10:23
47cbd6a
to
dd9f38f
Compare
hackerwins
force-pushed
the
presence-batch-move-presence
branch
from
July 7, 2023 10:32
dd9f38f
to
beb4ad0
Compare
Codecov Report
@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 51.50% 51.17% -0.33%
==========================================
Files 67 66 -1
Lines 6932 7006 +74
==========================================
+ Hits 3570 3585 +15
- Misses 2891 2947 +56
- Partials 471 474 +3
|
Co-authored-by: Yourim Cha <yourim.cha@navercorp.com>
* Allow users to pass multi nodes when calling Tree.edit * Add nodes validation to Tree.edit
hackerwins
force-pushed
the
presence-batch-move-presence
branch
3 times, most recently
from
July 14, 2023 08:36
ae4f6b4
to
9d263e3
Compare
hackerwins
force-pushed
the
presence-batch-move-presence
branch
from
July 14, 2023 08:43
9d263e3
to
bccd61c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move Presence from Client to Document
UpdatePresence
The UpdatePresence API has been removed, and the document and presence changes are now sent through the PushPull API. As a result, the presence is no longer passed as part of the Client but instead included within the change. The changePack now includes the presence.
WatchDocument
In the WatchDocument API, the request and response only include the client ID without the presence.
Which issue(s) this PR fixes:
Address #442
Special notes for your reviewer:
This PR is one of the separations from #542.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: