Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Presence to Document #577

Closed
wants to merge 7 commits into from
Closed

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jul 7, 2023

What this PR does / why we need it:

Move Presence from Client to Document

UpdatePresence

The UpdatePresence API has been removed, and the document and presence changes are now sent through the PushPull API. As a result, the presence is no longer passed as part of the Client but instead included within the change. The changePack now includes the presence.

  • as-is
image
  • to-be
image

WatchDocument

In the WatchDocument API, the request and response only include the client ID without the presence.

wat

Which issue(s) this PR fixes:

Address #442

Special notes for your reviewer:

This PR is one of the separations from #542.

Does this PR introduce a user-facing change?:

- The UpdatePresence API has been removed.
- Presence changes are now sent through the PushPull API, so the Change includes presence information and the ChangePack includes the snapshotPresence.
- In the WatchDocument API's request and response, only the client ID is passed without the presence.

Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins force-pushed the presence-batch-move-presence branch from 6ee616b to ed82e0d Compare July 7, 2023 10:12
@hackerwins hackerwins force-pushed the presence-batch-move-presence branch 2 times, most recently from 47cbd6a to dd9f38f Compare July 7, 2023 10:23
@hackerwins hackerwins force-pushed the presence-batch-move-presence branch from dd9f38f to beb4ad0 Compare July 7, 2023 10:32
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #577 (bccd61c) into main (2b15ac5) will decrease coverage by 0.33%.
The diff coverage is 29.32%.

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   51.50%   51.17%   -0.33%     
==========================================
  Files          67       66       -1     
  Lines        6932     7006      +74     
==========================================
+ Hits         3570     3585      +15     
- Misses       2891     2947      +56     
- Partials      471      474       +3     
Impacted Files Coverage Δ
api/converter/from_bytes.go 53.17% <0.00%> (-2.73%) ⬇️
api/converter/to_bytes.go 64.07% <0.00%> (-8.23%) ⬇️
client/options.go 13.33% <0.00%> (-24.17%) ⬇️
pkg/document/change/change.go 0.00% <0.00%> (ø)
pkg/document/change/checkpoint.go 92.00% <ø> (ø)
pkg/document/change/context.go 0.00% <0.00%> (ø)
server/rpc/admin_server.go 53.97% <0.00%> (ø)
client/client.go 13.66% <5.45%> (-1.67%) ⬇️
pkg/document/internal_document.go 17.20% <14.28%> (-4.47%) ⬇️
server/backend/database/change_info.go 21.05% <20.00%> (-3.09%) ⬇️
... and 9 more

chacha912 and others added 3 commits July 10, 2023 17:40
Co-authored-by: Yourim Cha <yourim.cha@navercorp.com>
* Allow users to pass multi nodes when calling Tree.edit

* Add nodes validation to Tree.edit
@hackerwins hackerwins marked this pull request as ready for review July 14, 2023 08:03
@hackerwins hackerwins force-pushed the presence-batch-move-presence branch 3 times, most recently from ae4f6b4 to 9d263e3 Compare July 14, 2023 08:36
@hackerwins hackerwins force-pushed the presence-batch-move-presence branch from 9d263e3 to bccd61c Compare July 14, 2023 08:43
@hackerwins hackerwins closed this Jul 14, 2023
@hackerwins hackerwins deleted the presence-batch-move-presence branch July 14, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants