Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please, inherit yaml-mode' from prog-mode' #27

Closed
Alexander-Shukaev opened this issue Mar 4, 2015 · 3 comments
Closed

Please, inherit yaml-mode' from prog-mode' #27

Alexander-Shukaev opened this issue Mar 4, 2015 · 3 comments

Comments

@Alexander-Shukaev
Copy link

The title speaks for itself. What is the reason that you decided to inherit from fundamental-mode? Some people (including me) have things like

(add-hook 'text-mode-hook 'fci-mode)
(add-hook 'prog-mode-hook 'fci-mode)

which make life easier, and that's exactly one of those features what proper mode inheritance was intended for.

Thank you.
@squiter
Copy link

squiter commented Jul 10, 2015

👍

wasamasa added a commit that referenced this issue Dec 15, 2015
@wasamasa
Derive from text-mode
97d507f 
Closes #17, #18, #27
@Alexander-Shukaev
Copy link
Author

Why from text-mode?

@wasamasa
Copy link
Collaborator

For the same reason rst-mode, xml-mode and tex-mode do. It's not a programming language.

@joewreschnig joewreschnig mentioned this issue Jul 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@squiter @Alexander-Shukaev @wasamasa