Fixed a code example and a spelling error #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables `barracks` to be used as the core of `choo`. It solves the previous questions that were left unanswered in the FAQ - [x] write docs - [ ] write code - [ ] write tests
| @@ -241,7 +241,7 @@ app.model({ | |||
| subscriptions: { | |||
| emitWoofs: (send) => { | |||
| // emit a woof every second | |||
| setInterval(() => send('print', { woof: 'meow?' }), 1000) | |||
| setInterval(() => send('print', { printWoofs: 'meow?' }), 1000) | |||
There was a problem hiding this comment.
this won't fly because line 248 expects a "woof" property to exist on the object
There was a problem hiding this comment.
Sorry, changed the wrong thing! 😓 It should be setInterval(() => send('printWoofs', { woof: 'meow?' }), 1000)
The argument in send should match the effect name, right?
There was a problem hiding this comment.
yup, exactly! - I like the name "printwoofs"
|
Oooh, nice, thanks! :D |
|
Updated the code example again 😄 |
|
Whoops, totes forgot to merge this - fixed in 3b6ef39. Thanks heaps! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading through your barracks documentation and found two small errors.
Good work on choo and barracks by the way! 🙌