Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra start() from docs #36

Closed
wants to merge 1 commit into from

Conversation

timwis
Copy link
Collaborator

@timwis timwis commented Jul 3, 2016

I'm assuming this is a typo?

@coveralls
Copy link

coveralls commented Jul 3, 2016

Coverage Status

Coverage remained the same at 94.488% when pulling 7c242f0 on timwis:docs-remove-extra-start into bc485ff on yoshuawuyts:master.

@yoshuawuyts
Copy link
Owner

Hah, perhaps confusingly, it's not! - So what's going on here is that:

const createSend = store.start({ noSubscriptions: true })

fires up everything but the subscriptions, and then

store.start()

fires up everything that hasn't been started yet; thus firing up the subscriptions. I agree that we should probably document this better; can imagine this does look confusing haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants