Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fuse from impl Merge for array #70

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

yoshuawuyts
Copy link
Owner

@yoshuawuyts yoshuawuyts commented Nov 14, 2022

Tracking issue: #22

Inlines the poll states on array::merge and removes the sort-based indexing. This results in a 3-10x speedups across the board:

compared to main branch

group                main                                   patch
-----                ----                                   -----
array::merge 10      3.25      4.2±0.26µs        ? ?/sec    1.00  1293.1±57.06ns        ? ?/sec
array::merge 100     9.41   376.3±25.42µs        ? ?/sec    1.00     40.0±1.13µs        ? ?/sec
array::merge 1000    9.54     40.0±1.72ms        ? ?/sec    1.00      4.2±0.06ms        ? ?/sec

compared to last release

❯ critcmp baseline patch  -f array::merge
group                baseline                               patch
-----                --------                               -----
array::merge 10      3.27      4.2±0.28µs        ? ?/sec    1.00  1293.1±57.06ns        ? ?/sec
array::merge 100     9.14   365.5±13.01µs        ? ?/sec    1.00     40.0±1.13µs        ? ?/sec
array::merge 1000    9.35     39.2±1.49ms        ? ?/sec    1.00      4.2±0.06ms        ? ?/sec

@yoshuawuyts yoshuawuyts changed the title inline pollstates for array::merge use pollstates in array::merge Nov 14, 2022
@yoshuawuyts yoshuawuyts changed the title use pollstates in array::merge Remove Fuse from impl Merge for array Nov 14, 2022
@yoshuawuyts yoshuawuyts merged commit 00acd05 into main Nov 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the array-inline-pollstate branch November 16, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant