Improve syntax highlighting

[mattdesl]

A minor irk for me is that the syntax highlighting is not accurate to GH, and it also tries to highlight non-code blocks (plain text with <pre>).

This improves it slightly, see the screen shots attached. However it might have other side-effects, so I will sit on it for a while and test.

I think ideally Pygments would be used to highlight exactly as it appears on GH, but this may involve doing it in server.js and then sending the HTML string back to client. The upside is that it will not have a flash of unstyled code.

Before fix:

After fix:

[maxkueng]

Looks much better (screenshots). Have you noticed any side effects yet?

Regarding Pygments: Is this what GitHub uses? It depends on Python. Not sure if this could be a problem. I think most people who have Node.js and/or npm installed will probably also have Python as node-gyp requires it. There's a pygmentize-bundled package on npm which bundles Pygments so users don't have to manually install Pygments themselves. I have never used it though.

Pygments would be used to highlight exactly as it appears on GH, but this may involve doing it in server.js and then sending the HTML string back to client.

Yes, because Pygments has to be started as a child process. I don't see a problem with having this code in the browser process (server.js) and sending it over to the renderer over IPC. It might even be the cleaner solution.

[mattdesl]

No issues with it yet.

[maxkueng]

Feel confident to merge it? I can create a "spin-off" issue for the Pygments stuff.

[yoshuawuyts]

Merged in 7a0523c, released as v1.7.1

[maxkueng]

Merged in 7a0523c, released as v1.7.1

👍

@yoshuawuyts: Can you push tags? 1.7.1 tag isn't there yet.

[yoshuawuyts]

Odd, somehow my script didn't always push tags. Now it should though 😅 - https://github.com/yoshuawuyts/dotfiles/blob/master/bin/npv#L16 Thanks!