Utilize Dependency Injection for ContactsRepository #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you didn't expect this, but I wanted to utilize some dependency injection.
ContactHelper
into aContactRepository
ContatsSource
enum to switch betweenDevice
andLocal
RepositoriesThere's no clear performance benefit from doing this, but the overall code looks cleaner and easy to understand.
And since the repository is a singleton now, we can do some caching to improve performance in the future.
PS: I had to do all the changes in one commit because the code was too intermingled.
Whether or not you use the changes is up to you. I just wanted to give you a heads up.