Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non existing redis keys #63

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

dysonfrost
Copy link
Collaborator

This PR is for the handling of redis keys which are not present while a dump is in progress.

@dysonfrost dysonfrost requested review from Bertg and butsjoh July 8, 2024 11:21
@dysonfrost dysonfrost self-assigned this Jul 8, 2024
@dysonfrost dysonfrost changed the title Jeremy/fix/handle non existing keys Handle non existing redis keys Jul 8, 2024
Copy link
Member

@Bertg Bertg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dysonfrost Is there a readson why we do our backup with this type of script, instead of using the SAVE and RESTORE . I understand, i guess its becaause this DB is manged, and so we can't take the backup.

Wouldn't it hen - maybe - make more sense to just use the backups of digital ocean themselves?

@dysonfrost
Copy link
Collaborator Author

Approved

@dysonfrost Is there a readson why we do our backup with this type of script, instead of using the SAVE and RESTORE . I understand, i guess its becaause this DB is manged, and so we can't take the backup.

Wouldn't it hen - maybe - make more sense to just use the backups of digital ocean themselves?

that's correct, however DigitalOcean doesn't provide an adhoc mechanism to restore from backup with Redis.

@dysonfrost dysonfrost merged commit 10e9a42 into main Jul 8, 2024
@dysonfrost dysonfrost deleted the jeremy/fix/handle_non_existing_keys branch July 8, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants