Create madoka yabuuchi #19
Conversation
There was a problem hiding this comment.
Hello, thank you for making a pull request. I review all changes and in my testing, I ran into a number of issues. First, the waifu doesn't come up in the search prediction algorithm, 2nd, the parser gave up reading the file as it contained an issues that I highlighted, last, I'm not sure where you got your info other than the month, day, and name.
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
add .json to the end of the filename
| "image" : "https://cdn.myanimelist.net/images/characters/8/379321.jpg", | ||
| "japanese-name" : "藪内 円", | ||
| "year" : 2019, | ||
| "month" : 08, |
There was a problem hiding this comment.
This is invalid JSON, the JSON parser doesn't understand what 08 means. Replace this with 8.
| "english-name" : "Madoka yabuuchi", | ||
| "image" : "https://cdn.myanimelist.net/images/characters/8/379321.jpg", | ||
| "japanese-name" : "藪内 円", | ||
| "year" : 2019, |
There was a problem hiding this comment.
Where does this number come from? You need to say where this number comes from in the notes. Here's an example of some notes
is-your-waifu-legal/waifus/sucy manbavaran.json
Lines 10 to 12 in 92ea548
| "year" : 2019, | ||
| "month" : 08, | ||
| "day-of-month" : 31, | ||
| "age-in-show": 16, |
There was a problem hiding this comment.
Same thing here, you don't have any sources that say that she's 16 during the show.
Adding Madoka to the list!