Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Add monthly downloads badge #274

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

ayushjain01
Copy link
Contributor

Add monthly downloads badge for mypy-boto3-builder and replace downloads badge for boto3-stubs, types-aiobotocore and types-aioboto3. View more at - https://piptrends.com/package/mypy-boto3-braket

Notes

Please describe your changes here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change

Checklist

All of these are optional:

  • I have performed a self-review of my own code
  • I have run ./scripts/before_commit.sh to follow the style guidelines of this project
  • I have tested my code changes

Thank you!

Add monthly downloads badge for mypy-boto3-builder and replace downloads badge for boto3-stubs, types-aiobotocore and types-aioboto3.
@vemel
Copy link
Collaborator

vemel commented May 28, 2024

Thank you a lot! Looks awesome, I am going to change all links from pepy to piptrends later.

@vemel vemel merged commit 0b8bf9b into youtype:main May 28, 2024
@ixmatus
Copy link

ixmatus commented Jun 27, 2024

@vemel a colleague of this person tried to open this exact PR against a project I'm the maintainer for as well (ixmatus/inflector#16). This is a promotional campaign and they (or colleagues) appear to be doing it on reddit too, I think this is suspicious activity. They are creating an external dependency on a web property that (as far as I can tell) is not officially blessed by pypi. I recommend reverting this change.

Users can get package statistics from libraries.io which is linked to directly by pypi itself.

@ayushjain01
Copy link
Contributor Author

Thank you for your feedback and concerns. I'd like to clarify that this is not a promotional campaign. As stated in the PR description, our intention is simply to share a tool we have developed, which we believe could be beneficial to the community.

Our badge system offers highly accurate statistics, which is why we wanted to make it available. If the link to the pip trends page is a concern, we are more than willing to remove it.

We respect your decision if you prefer not to add more badges to your README. Our primary goal is to address any misunderstandings and assure you that this is a genuine effort to contribute to the open-source community by sharing our work on GitHub.

Thank you for considering our contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants