Port from Caporal to Commander #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2022
|
@andersk the pr looks great! Would you mind updating from latest so we can confirm passing tests? Thanks again! |
|
Sure, rebased. (You’ll need to re-approve the GitHub Actions workflow.) |
andersk
force-pushed
the
commander
branch
3 times, most recently
from
cc1f539
to
424e63a
Compare
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Caporal appears to be dead upstream, and pins an insecure version of lodash. Commander is actively maintained, has no dependencies, and is much faster as a bonus. It’s missing Caporal’s colored logging feature, but that’s easy to reimplement. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
yowainwright
approved these changes
Jul 20, 2022
|
@andersk Awesome stuff! I'll release this as a major release [just to be safe] tomorrow. |
apepper
added a commit
to Scrivito/scrivito_example_app_js
that referenced
this pull request
Aug 1, 2022
This version finally replaces Caporal with Commander (see [1]). Without caporal there is also no longer the need to "override" specific lodash versions. [1] yowainwright/es-check#159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caporal appears to be dead upstream (mattallty/Caporal.js#243), and pins an insecure version of lodash (mattallty/Caporal.js#212, mattallty/Caporal.js#224, mattallty/Caporal.js#239). Commander is actively maintained, has no dependencies, and is much faster as a bonus. It’s missing Caporal’s colored logging feature, but that’s easy to reimplement.