-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsing of product data #9
Conversation
I think it's a greedy string. nibepi does some weird things with the first byte + 5 or similar to get the length. https://github.com/anerdins/nibepi/blob/080db44d7ecca82b5c75bd7defd2f078687ab877/index.js#L383 |
08a99ca
to
2fec8c0
Compare
I agree that nibepi does some weird stuff... GreedyString seems to be right. |
I think you want to add some logic here: |
Yes probably. Any thoughts on how it should be exposed? I think it could be sent to other addresses than MODBUS40 |
I can implement it myself. But tomorrow. I have a good idea how to do this.
Jevgeni
… 10 сент. 2022 г., в 15:05, Joakim Plate ***@***.***> написал(а):
Yes probably. Any thoughts on how it should be exposed? I think it could be sent to other addresses than MODBUS40
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
|
Sounds good. Ps. Initial native home assistant implementation: https://github.com/home-assistant/core/compare/dev...elupus:home-assistant:nibe/local?expand=1 Just plain sensors for now. Will look at the other fun stuff later. |
Take a look. I am not confident in |
I think we should cache the product data. It seems its only sent quite infrequently. Since we cant trigger it to be sent, it feel like a cache of last received data might be in order? |
It is sent every 15 seconds. I'd wait for this message as part of initial connection process. The response can be cached, yes. |
I think this can be merged already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No description provided.