Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: TypeScript declarations #38

Merged
merged 24 commits into from
Jan 31, 2023
Merged

Feature: TypeScript declarations #38

merged 24 commits into from
Jan 31, 2023

Conversation

ysa23
Copy link
Owner

@ysa23 ysa23 commented Jan 30, 2023

Add typescript declaration files to all exports

#32

@ysa23
feat(typescript): add typescript and initial declaration file
c976bb6
@ysa23
chore(statsd socket): add declaration file
331265e
@ysa23
fix(build): fix build declaration step name
3a8da6c
@ysa23
chore(build): build declaration files on publish
e915ead
@ysa23
chore(console reporter): add console reporter and Tags type
30e6204
@ysa23
chore(reporters): add interface for reporters
15a2f2b
@ysa23
chore(datadog reporter): add declaration file
4c36e46
@ysa23
chore(grapite): add declaration file
6f2a67a
@ysa23
chore(in memory): add declaration file
46321e5
@ysa23
chore(string): add declaration file
508dc1b
@ysa23
chore(space): add declaration for space
e97f625
@ysa23
chore(metrics): add declaration file
2dd218e
@ysa23
chore(index): add declaration file
bc55f90
@ysa23
chore(package): increment version
6b594e9
@ysa23
fix(datadog reporter): add close function
aecf75d
@ysa23
fix(in memory reporter): explicitly declare array type
cedf565
@ysa23
chore(index): export reporter interface
7091fa6
@ysa23
chore(index): export types
6c61938
@ysa23 ysa23 added the enhancement New feature or request label Jan 30, 2023
@ysa23 ysa23 requested a review from igor-dv January 30, 2023 12:22
@ysa23 ysa23 self-assigned this Jan 30, 2023
@ysa23 ysa23 mentioned this pull request Jan 30, 2023
Closed
@ysa23 ysa23 linked an issue Jan 30, 2023 that may be closed by this pull request
Add typescript definitions #32
Closed
igor-dv
igor-dv reviewed Jan 30, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
igor-dv
igor-dv approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it will be better just rewrite it in TS. there are too many declarations just to maintain them independently..
but approving anyway =)

@ysa23
Copy link
Owner Author

ysa23 commented Jan 31, 2023

@igor-dv - you are right, but its too much effort to do at this moment (its basically a complete re-write of everything in the package). I will open a task for this and will convert it to typescript in stages.

@ysa23 ysa23 merged commit 78a693e into master Jan 31, 2023
@ysa23 ysa23 deleted the feat/typescript-declarations branch January 31, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-dv igor-dv igor-dv approved these changes

Assignees

@ysa23 ysa23

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add typescript definitions
2 participants
@ysa23 @igor-dv