Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual artifacts when using blur with use-damage #50

Closed
yshui opened this issue Nov 10, 2018 · 3 comments
Closed

Visual artifacts when using blur with use-damage #50

yshui opened this issue Nov 10, 2018 · 3 comments
Labels
bug heritage Bugs inherited from the original compton

Comments

@yshui
Copy link
Owner

yshui commented Nov 10, 2018

GPU, drivers, and screen setup

NVIDIA GTX 1060, driver version: 410.73

Compton version

git-v0.1_beta2-87-g316eac0-2017-04-30

Compton configuration:

backend = "xrender";
blur-background = true;
clear-shadow = true;

Steps of reproduction

Start compton, place a transparent window on top of another window that updates frequently

Expected behavior

No artifacts

Current Behavior

Artifacts, see attached clip

Other details

This bug is caused by incorrect handling of pixels at the edge of damage area in compton's blur code.

blur_artifacts.zip

@yshui yshui added the heritage Bugs inherited from the original compton label Nov 10, 2018
@yshui yshui added this to the v6 milestone Nov 10, 2018
@yshui
Copy link
Owner Author

yshui commented Nov 10, 2018

This is not very hard to fix, except when multi-pass blur is used. Therefore I think it is probably better to remove the multi-pass blur feature.

Object here if you want to keep the feature.

@yshui yshui added the bug label Nov 10, 2018
@yshui
Copy link
Owner Author

yshui commented Nov 25, 2018

There is a undocumented option resize-damage that makes the damage area bigger to hack around this problem.

This is not an ideal solution, please don't use that.

@yshui yshui changed the title Visual artifacts when using blur with the xrender backend Visual artifacts when using blur with the xrender backend or buffer age Feb 1, 2019
@yshui yshui modified the milestones: v6, v7 Jun 12, 2019
@yshui yshui changed the title Visual artifacts when using blur with the xrender backend or buffer age Visual artifacts when using blur with use-damage Jun 24, 2019
yshui added a commit that referenced this issue Jul 7, 2019
This is done by extending the blur area internally when process
blurring.

Ping: #50, cause this fixes that problem but only when using the
experiemental backends.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
yshui added a commit that referenced this issue Jul 7, 2019
Similar fix to 6d646b5.

Also ping #50

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@yshui yshui removed this from the v7 milestone Jul 7, 2019
yshui added a commit that referenced this issue Jul 26, 2019
Fix blur artifacts in experimental backends

Closes #194 #50
@yshui
Copy link
Owner Author

yshui commented Feb 7, 2024

should have long been fixed. although corner cases creeps back up from time to time. no reason to keep this one open.

@yshui yshui closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug heritage Bugs inherited from the original compton
Projects
None yet
Development

No branches or pull requests

1 participant