Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix segfaults when the HOME environment variable is not set #1157

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

absolutelynothelix
Copy link
Collaborator

fixes #1148.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (b368072) 37.40% compared to head (cacb45f) 37.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1157      +/-   ##
==========================================
+ Coverage   37.40%   37.54%   +0.13%     
==========================================
  Files          49       49              
  Lines       11201    11203       +2     
==========================================
+ Hits         4190     4206      +16     
+ Misses       7011     6997      -14     
Files Coverage Δ
src/config.c 51.55% <0.00%> (-0.15%) ⬇️
src/config_libconfig.c 57.50% <0.00%> (-0.19%) ⬇️

... and 2 files with indirect coverage changes

src/config.c Outdated Show resolved Hide resolved
Copy link
Owner

@yshui yshui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yshui yshui merged commit 496452c into yshui:next Dec 22, 2023
16 checks passed
@absolutelynothelix absolutelynothelix deleted the fix-segfaults-when-homeless branch December 22, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

picom --invert-color-include fails when the HOME env is unset
2 participants