Support Menu Icon

[enigma9o7]

No description provided.

[codecov]

Codecov Report

Merging #598 (8c26f2d) into next (3680d32) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next     #598      +/-   ##
==========================================
+ Coverage   39.88%   40.05%   +0.16%     
==========================================
  Files          46       46              
  Lines        9449     9449              
==========================================
+ Hits         3769     3785      +16     
+ Misses       5680     5664      -16     

Impacted Files	Coverage Δ
src/picom.c	68.41% <0.00%> (+0.63%)	⬆️
src/win.c	68.98% <0.00%> (+0.84%)	⬆️

[arielnmz]

Quick question why would we want an icon for this?

[enigma9o7]

Well for one, its the only thing in my menu tree without an icon and had to change the desktop file to make it show one.

It looks nicer with an icon than a blank spot in menu? I dunno. Compton has an icon.

But I think you may ask, why not just hide the menu entry? Well that makes it harder to launch.

Why not autostart? Cuz I only use it when I want it, otherwise it slows down moving windows around.

Why not use window manager's option to load/unload it? If I do it that way it uses a config file shipped with the distro that adds transparency and effects to applications menus, whereas I prefer default behavior with no config file. I use picom when I want one of three things; the transparency setting in terminology terminal to work, background transparency in conky to work, or rounded corners and transprancy in plank dock to work.

[arielnmz]

Makes sense, but I don't think command line programs or services without a GUI have to have an icon entry, at least by default, that's probably something the end user could do if needed11:46, 6 de marzo de 2021, enigma9o7 <notifications@github.com>: Well for one, its the only thing in my menu tree without an icon and had to change the desktop file to make it show one. It looks nicer with an icon? I dunno. But I think you may ask, why not just hide the menu entry? Well that makes it harder to launch. Why not autostart? Cuz I only use it when I need it, otherwise it slows down moving windows around. —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe. -- Sent from Yandex.Mail for mobile

[yshui]

I think this makes sense, and I don't think there is any downside to having an icon, even if it doesn't look super nice.

[yshui]

Thanks for the PR.