Use mini_magick instead of rmagick #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diskshima
commented
Nov 5, 2018
| end | ||
|
|
||
| def to_256color(pix, memo) | ||
| return -1 if pix.opacity.positive? | ||
| # TODO: Need to figure out how to extract opacity. | ||
| # return -1 if pix.opacity.positive? |
There was a problem hiding this comment.
こちら、 opacity が正の場合、-1 で良いのでしょうか？
transparent が正なら、透明の場合に無視する、というロジックが理解できるのですが…
There was a problem hiding this comment.
ここは透明の場合に-1を返す、ということを意図しています。
手元で試したところ、不透明の場合にopacity=0、完全に透明の場合にopacity=65535になるようなので、上記コードになっています。
diskshima
commented
Nov 5, 2018
| end | ||
| end | ||
| h.max_by { |a| a[1] }[0] | ||
| end | ||
|
|
||
| def to_256(pix) | ||
| [pix.red / 257, pix.green / 257, pix.blue / 257] | ||
| red, green, blue = pix | ||
| [red % 256, green % 256, blue % 256] |
There was a problem hiding this comment.
こちら、僕の変更は意図として合っていると思うのですが、rmagick の際の数値が分からないため、正確かどうか不安な状態です。
There was a problem hiding this comment.
rmagickでは画素値が0 ~ 65535の値となるので、0 ~ 255の値に変換するために割り算をしています。257はバグでした。256で除すのが正しいです。
ただ、mini_magickはデフォルトで0 ~ 255の値を返すようなので、そもそもto_256自体が不要のようです。
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmagickが古いImageMagickを要求してきたため、mini_magickに置き換えてみました。以下の点、相談できればと思います。