Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle edge case where key might expire in the middle of the multi exec for redis store #44

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

jmacpherson
Copy link
Contributor

Discussion of the edge case: https://www.bennadel.com/blog/2785-volatile-keys-can-expire-mid-multi-transaction-in-redis-jedis.htm

Evidence of the ability to reprod with this library:
Screen Shot 2022-04-26 at 3 21 07 PM

@julienwilmet
Copy link
Contributor

Does this also fix #39 and #44 ?

@jmacpherson
Copy link
Contributor Author

Does this also fix #39 and #44 ?

I can't speak to the X-RateLimit-Reset bug mentioned in #39, but it does address the ttl -1 issue, without resetting the counter back to 1 when doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants