feat: added option to customize the key of the object response #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -65,7 +65,8 @@ const createAccountLimiter = RateLimit.middleware({ | |||
| timeWait: 3*1000, // slow down subsequent responses by 3 seconds per request | |||
| max: 5, // start blocking after 5 requests | |||
| prefixKey: 'post/user', // to allow the bdd to Differentiate the endpoint | |||
| message: "Too many accounts created from this IP, please try again after an hour" | |||
| message: "Too many accounts created from this IP, please try again after an hour", | |||
| messageKey: "error" | |||
There was a problem hiding this comment.
maybe set it as message since it is the default behaviour
There was a problem hiding this comment.
Yeah makes sense, updated!
There was a problem hiding this comment.
cool!
Is this urgent for you? If it is, I can release it asap otherwise I'll just wait the resolution of #47 and make a release with both changes
|
live in v1.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.