Has permissions for some of the pages #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revious-verison-works
|
@markspolakovs I have commented/fixed the things you have pointed out |
|
@markspolakovs done the rest, happy to merge or any other fixes? |
|
@markspolakovs more comments and corrections |
markspolakovs
requested changes
Aug 6, 2023
|
@markspolakovs is that better answers |
|
@markspolakovs are the changes good for you? |
|
Will take another look shortly - what order is this PR in the stack relative to #8? They're both targeted to |
|
The UserStripped does get swapped back to User eventually |
…on-works' into liam.burnand/this-previous-verison-works
markspolakovs
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version block has working permissions and also the